fix: include tag_name in updateRelease #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When release with assets is needed we update previously created draft release by adding tag_name in API call
|
FYI: I work in @kickapoo's sister team, and while I'm not a node developer specifically, I am a javascript developer, and I'm happy to help out as best I can. |
Fix lint errors.
|
I've fixed the lint errors and the failing tests in two fixup-commits, intended to be squashed into the main commit before merge, but I will of course be happy to edit the commits, if you have any other preference. |
|
Seem can not add you as reviewer so cc , @gr2m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
untagged release when a release includes assets upload.
Fix
When release with assets is needed, we update previously created draft release (in order to attach assets) by adding
tag_namein github api call .tag_nameoption in not required based on git docs.Details in #362
Must read comment: #362 (comment)
NOTE
DRAFT PR since my skills aren't node based (python dev). Need time to understand/learn/explore the unit tests failures.
Help is appreciated.