Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a benchmark which uses Google benchmark library #1392
Add a benchmark which uses Google benchmark library #1392
Changes from 73 commits
3eefad0
cc997aa
8235841
3fd4e01
202fb59
ba8be94
566566d
fe7d42d
bcd9d70
943f04d
5d346a5
e770341
345b5e7
8ed27cf
16fea77
82a8d93
b03aabd
50e76bb
0b56c68
ad48e8a
f0aab9d
9520bb0
4be134f
88f9f4a
96e9c5d
ea31445
dba91ea
62d8105
dda4c8f
ebf5d75
bb4b18d
d8f505b
746a174
44d309d
bb959b2
842680d
590be53
10169fa
17d5e8e
7bb2070
0642949
d76289a
4657572
d8db674
802e4f7
3564c8b
227a661
b6575c9
21e85d9
1022065
915817d
2881040
4b0c896
00997b6
7795cfc
7107fd6
ea982b7
caf6c64
72f6bd2
b6d7e98
5e8e056
27b4619
95b6562
d6e90c0
f9e4cfb
b9aad7d
90faf97
66b3e14
1588009
a8a2a46
ed12ae4
80152bf
6b861d7
58701ed
557839a
7ee9f25
1ecf4d6
bc5be8a
bb0e73d
9dd6134
f5d1a8b
de4ae9c
b1f00ab
7774cb6
10f40c2
419c63e
a6a9cb1
fe12995
9fc6e6e
bc4ab17
948d1cf
602ddd9
800f287
e8efae5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
--pcap-file
is a mandatory parameter (and the only param for now), maybe we don't need the param itself and can run the benchmark like this:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seladb The problem is arguments are also used by google benchmark. It supports some flags as default, for example
--benchmark_filter
or--benchmark_out_format
etc. So--pcap-file
actually not only parameter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, so we can keep it 👍