-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GVCP support #1357
Draft
tigercosmos
wants to merge
79
commits into
seladb:dev
Choose a base branch
from
tigercosmos:gvcp_0410
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
GVCP support #1357
Changes from 1 commit
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
0184c8c
GVCP init
tigercosmos 4d6ebcb
Merge branch 'dev' of github.com:seladb/PcapPlusPlus into gvcp_0410
tigercosmos e0a0d85
fix minor build issues
tigercosmos 4630418
some fixes
tigercosmos c55eccf
implement discovery
tigercosmos c68f703
Merge branch 'dev' into gvcp_0410
tigercosmos d5dad27
wip
tigercosmos f350012
fix test
tigercosmos d029b21
fix
tigercosmos d187ba8
add gvcp pcap files
tigercosmos d1cb68c
add gvcp hex data
tigercosmos 36ef8cf
update test data
tigercosmos 77d058d
update test
tigercosmos 3784a5f
fix struct data layout, getter
tigercosmos 7eaa8a1
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos d974666
format
tigercosmos 711a973
add test
tigercosmos 73e0ea9
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos f8cfda3
force ip
tigercosmos 13ac030
remove try block
tigercosmos 1d1b095
Merge remote-tracking branch 'upstream/master' into gvcp_0410
tigercosmos 38b96d0
format + new test
tigercosmos f0a3aca
add test
tigercosmos 3082195
new test & refactoring
tigercosmos 656c690
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 55d485c
add GvcpReadRegisterAcknowledge
tigercosmos 567052a
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 7360cef
update
tigercosmos 11b7bd0
doc
tigercosmos 9c4ae38
add test
tigercosmos 096709d
code review
tigercosmos 66754c6
Merge branch 'dev' into gvcp_0410
tigercosmos cbf2024
Merge branch 'dev' into gvcp_0410
tigercosmos 3dfaae0
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 9f57c1e
change the order
tigercosmos ec4a371
add parseGvcpLayer
tigercosmos bdca33a
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos aad6933
wip: architecture change
tigercosmos 1497efb
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 1907531
update constructor
tigercosmos c2786e9
tmp
tigercosmos 9cf406f
update
tigercosmos b9b6fe8
improve parseGvcpLayer
tigercosmos b144e60
update parseGvcpLayer
tigercosmos 27f5bfa
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos ce0fd86
format
tigercosmos c96d4ad
fix cppcheck
tigercosmos 862fb05
fix doc
tigercosmos 70ea57f
fix precommit
tigercosmos 1c45bc6
simplify the code
tigercosmos 655fef5
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 1b96823
fix
tigercosmos fede80b
Merge branch 'dev' into gvcp_0410
tigercosmos 6038329
move the method to layers
tigercosmos deedd82
fix
tigercosmos ea6c556
remove author
tigercosmos 4b7b949
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 8c307cf
fix
tigercosmos 6758558
forward declare the function in SystemUtil.h
tigercosmos aae6efb
rm
tigercosmos 221fd37
add
tigercosmos 369bbfe
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos e9cd0f4
add missing "/// @file"
tigercosmos 5e9877b
naming issues
tigercosmos 722302d
remove protect.
tigercosmos fd21069
make functions public
tigercosmos cd8ddf4
add some comments
tigercosmos 8300e1c
capital GVCP in comments
tigercosmos e8b67f0
comments format
tigercosmos 054e73d
move all GVCP headers under `internal`
tigercosmos 081ef57
fix comments
tigercosmos 9712045
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 73040e0
more comment
tigercosmos de1d864
Merge remote-tracking branch 'upstream/dev' into gvcp_0410
tigercosmos 4412a48
hide implementation
tigercosmos be3e94e
return PayloadLayer if it's not GVCP
tigercosmos dffd171
use switch
tigercosmos d1ca9a2
Unknown command
tigercosmos 97a74a1
lint
tigercosmos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Unknown command
- Loading branch information
commit d1ca9a27a97410f76fcb2b2375c27d7c17227f83
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I could see,
gvcpCommandSet
is only used in the current file.It would be better to change the symbol to use internal linkage, rather than external, as it is not declared in
GvcpLayer.h
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Also maybe have the set as
const
?