-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP packet fragmentation support #1212
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1212 +/- ##
=======================================
Coverage 82.40% 82.40%
=======================================
Files 163 163
Lines 20938 20938
Branches 7906 7906
=======================================
+ Hits 17254 17255 +1
+ Misses 3013 3012 -1
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8b150b5
to
22a85a0
Compare
124cba5
to
a1cbffe
Compare
reassembly implementation
a1cbffe
to
005f159
Compare
005f159
to
1b0669b
Compare
The payload is a JSON object. HTTP1_chunk_1 holds the HTTP 200 message. HTTP1_chunk_2 holds the first part of the packet. HTTP1_chunk_3 holds the last part of the packet.
bb55a98
to
2f7dcb1
Compare
Test is failing as, among other issues, the format may not work correctly.
Apparently the packet types are unable to detect chunk continuations. The sample capture is https://wiki.wireshark.org/uploads/__moin_import__/attachments/SampleCaptures/http-chunked-gzip.pcap
@jpcofr are you still working on this PR? |
@seladb Currently, no. I am planning to continue working on it soon. |
@jpcofr this PR has been open for a very long time. Maybe we can close it and you can work on it on a separate branch and open another PR once ready? |
No description provided.