Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cooldown time to Tendermint #384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Move cooldown time to Tendermint #384

wants to merge 2 commits into from

Conversation

yzang2019
Copy link
Collaborator

@yzang2019 yzang2019 commented Dec 27, 2023

Describe your changes and provide context

Auto remediation is controlled at the Tendermint level, we should apply cooldown time in the upper layer, otherwise, tendermint doesn't really know if we have successfully restarted or not.

Testing performed to validate your change

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (daecc34) 55.38% compared to head (86214a2) 55.37%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   55.38%   55.37%   -0.02%     
==========================================
  Files         620      620              
  Lines       51605    51583      -22     
==========================================
- Hits        28582    28563      -19     
+ Misses      20940    20937       -3     
  Partials     2083     2083              
Files Coverage Δ
server/util.go 42.05% <100.00%> (-0.57%) ⬇️
x/accesscontrol/keeper/msg_server.go 50.00% <ø> (-50.00%) ⬇️
server/start.go 21.91% <0.00%> (+0.36%) ⬆️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants