Update module and moduleResolution #1650
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempting to address issue #1483.
Changes
--module CommonJs
with--module Node16
. Source--module ES2015
with--module ES2022
. WhileNode16
is recommended, it only works iftype
is set tomodule
inpackage.json
. SourceAdditional thoughts
I have considered removing
CommonJs
entirely since it was mentioned a long time ago and the only place it is used here are inoss-npm-package
andprivate-npm-package
. I am not very well-versed in library conventions so I have left them as is but let me know if we should only emitesm
only.Also, not sure if this should be in a changeset 🤔