-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Output .mjs for hybrid packages #1508
base: main
Are you sure you want to change the base?
Conversation
|
This reverts commit 79e60c4.
await runBuild({ | ||
bundle: true, | ||
compilerOptions: { | ||
...compilerOptions, | ||
module: ModuleKind.ESNext, | ||
}, | ||
debug, | ||
entryPoints, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these entryPoints
are not correct for bundle: true
. Strictly speaking it should only output the root lib/index.mjs
unless more exports
are defined.
Snapshots via
cjs-mjs-output
tag: https://www.npmjs.com/package/skuba?activeTab=versionsnpm i skuba@cjs-mjs-output
This is an experimental feature that currently requires:
package.json
To do:
declaration
andremoveComments
in this mode, in pursuit of zero configbuild-package
as a separate command? It may be better to consolidate onbuild
with support for configuration; we can setpackage.json#/skuba/build
toesbuild
today, and we could add an option for e.g.hybrid
output.lib-commonjs
andlib-es2015
output? How safe will it be to switch to esbuild and modern targets?skuba lint
autofixes or askuba migrate
for ^?