Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rekor UI e2e tests v2 #37

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ssulka
Copy link
Contributor

@ssulka ssulka commented Nov 23, 2024

No description provided.

Copy link
Contributor

@osmman osmman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looking good, only need some small changes

}

BeforeAll(func() {
err = testsupport.CheckMandatoryAPIConfigValues(api.OidcRealm)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add api.RekorUIURL

appURL := api.GetValueFor(api.RekorUIURL)

setup := func() G {
launch := launcher.New().Headless(false) // if you want to see process of testing realtime, just rewrite true to false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it configurable for example by CI env variable. We will need to run these tests in our CI in headless mode

DeferCleanup(func() {
os.RemoveAll(tempDir)
})
dir, err = os.MkdirTemp("", "repository")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp directory is missing DeferCleanup

@@ -16,6 +16,8 @@ export SIGSTORE_REKOR_URL=$COSIGN_REKOR_URL
export REKOR_REKOR_SERVER=$COSIGN_REKOR_URL
export SIGSTORE_OIDC_CLIENT_ID=trusted-artifact-signer
export TSA_URL=$(oc get timestampauthorities -o jsonpath='{.items[0].status.url}')/api/v1/timestamp
export REKOR_UI_URL=$(oc get rekor -o jsonpath='{.items[0].status.rekorSearchUIUrl}' -n trusted-artifact-signer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not specify namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants