Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing ray tutorial #856

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix failing ray tutorial #856

merged 3 commits into from
Oct 16, 2024

Conversation

uri-granta
Copy link
Collaborator

@uri-granta uri-granta commented Jun 12, 2024 •
edited
Loading

This reverts commit 7f45a45 and adds some better logging in case this fails again.

Related issue(s)/PRs:

Summary

...

Fully backwards compatible: yes / no

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@uri-granta uri-granta marked this pull request as ready for review October 16, 2024 07:59
hstojic
hstojic approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@uri-granta uri-granta merged commit d6f70ca into develop Oct 16, 2024
14 checks passed
@uri-granta uri-granta deleted the uri/fix_ray_tutorial branch October 16, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstojic hstojic hstojic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-granta @hstojic