Greenwood confidence interval #400
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
Thanks for your pull request. Can you please rebase on the latest master branch which contains fixes to CI |
TristanFauvel
force-pushed
the
Greenwood_confidence_interval
branch
from
ce1824c
to
5fb8bb9
Compare
|
Sorry, I forgot to sync my fork before sending the PR. However, some of the tests unrelated to the PR failed (always with an AssertionError: Regex pattern did not match.) These tests also failed on the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What does this implement/fix? Explain your changes
Implementation of the Greenwood confidence interval for KM estimation, in addition to the log-log confidence interval. See https://www.math.wustl.edu/~sawyer/handouts/greenwood.pdf for details. The Greenwood CI is useful for calibration tests.