Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl CordicNumber for FixedI128 #4

Open
lemmih opened this issue Jun 17, 2021 · 1 comment
Open

impl CordicNumber for FixedI128 #4

lemmih opened this issue Jun 17, 2021 · 1 comment

Comments

@lemmih
Copy link

lemmih commented Jun 17, 2021

Hi, are there any hidden pitfalls for implementing CordicNumber for FixedI128?

@yasammez
Copy link

It seems that the reason is that the code which builds the cordic tables uses the builtin floating point types and Rust doesn't have f128 in stable yet (cf. rust-lang/rust#116909 ). Once that feature lands, I'd be willing to give it a shot.

Also, I wonder if the tables can be built at compile time by a const function or macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants