Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CSV from the upgrade helper results #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generate CSV from the upgrade helper results #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion Console/UpgradeHelperCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,28 @@
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Magento\Framework\App\Filesystem\DirectoryList;
use Magento\Framework\File\Csv;
use Magento\Framework\Filesystem;

class UpgradeHelperCommand extends Command
{
private $runner;
private $csvProcessor;
private $filesystem;
private $directoryList;

public function __construct(
Runner $runner
Runner $runner,
Csv $csvProcessor,
DirectoryList $directoryList,
Filesystem $filesystem
) {
parent::__construct(null);
$this->runner = $runner;
$this->csvProcessor = $csvProcessor;
$this->filesystem = $filesystem;
$this->directoryList = $directoryList;
}

protected function configure()
Expand All @@ -32,12 +44,22 @@ protected function execute(InputInterface $input, OutputInterface $output)
$diff = file($input->getArgument('diff'));
$result = $this->runner->run($diff);

$fileDirectoryPath = $this->directoryList->getPath(DirectoryList::ROOT);
$fileName = 'UpgradeHelperResult_'.date('m-d-Y').'.csv';
$filePath = $fileDirectoryPath . '/' . $fileName;
$data['headers'] = ['Patched', 'Customized', 'Reviewed (Yes / No)', 'Notes'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make the columns "Type", "Patched" and "Customized". The other two columns shouldn't be in the CSV output as they're unique to our review process, not generally a concern of this module.


foreach ($result as $type => $items) {
$output->writeln('-------- ' . $type . ' --------');
foreach ($items as $patched => $customized) {
$data[] = [$patched, $customized];
$output->writeln('Patched: ' . $patched);
$output->writeln('Customized: ' . $customized);
}
}
$this->csvProcessor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want something like an output flag to determine if it should be output as CSV or printed to the terminal.

->setEnclosure('"')
->setDelimiter(',')
->saveData($filePath, $data);
}
}