Generate CSV from the upgrade helper results #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpchadwick
requested changes
Apr 24, 2020
| $fileDirectoryPath = $this->directoryList->getPath(DirectoryList::ROOT); | ||
| $fileName = 'UpgradeHelperResult_'.date('m-d-Y').'.csv'; | ||
| $filePath = $fileDirectoryPath . '/' . $fileName; | ||
| $data['headers'] = ['Patched', 'Customized', 'Reviewed (Yes / No)', 'Notes']; |
There was a problem hiding this comment.
Let's make the columns "Type", "Patched" and "Customized". The other two columns shouldn't be in the CSV output as they're unique to our review process, not generally a concern of this module.
| $output->writeln('Patched: ' . $patched); | ||
| $output->writeln('Customized: ' . $customized); | ||
| } | ||
| } | ||
| $this->csvProcessor |
There was a problem hiding this comment.
I think we probably want something like an output flag to determine if it should be output as CSV or printed to the terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate CSV from the upgrade Helper results