Make schemagen generate compilable code and add test for it #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/fix-schemagen-test
branch
from
f4a55d4
to
2f653fe
Compare
| @@ -30,7 +30,7 @@ func TestSchemagen(t *testing.T) { | |||
|
|
|||
| b := runSchemagen(t, "foobar") | |||
|
|
|||
| const goldenFile = "testdata/models.go.txt" | |||
There was a problem hiding this comment.
What's the reason for a file name change?
There was a problem hiding this comment.
It has changed since I want to test generated code for real
cmd/schemagen/schemagen.go
Outdated
Comment on lines
123
to
124
| if c.Type == "duration" && !existsInSlice(imports, "github.com/gocql/gocql") { | ||
| imports = append(imports, "github.com/gocql/gocql") |
There was a problem hiding this comment.
Why adding v2 to gocql? I thought we add v2 to gocqlx not gocql.
dkropachev
force-pushed
the
dk/fix-schemagen-test
branch
5 times, most recently
from
4cbd1cd
to
5396809
Compare
dkropachev
force-pushed
the
dk/fix-schemagen-test
branch
from
5396809
to
7b1907f
Compare
dkropachev
changed the title
sylwiaszunejko
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that
schemagendoes not generate compilable file after switching fromv1tov2Make it compilable and have a test for it