(feat): read_lazy for xarray reading + read_elem_as_dask -> read_elem_lazy
#1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
- Coverage 86.99% 84.81% -2.18%
==========================================
Files 40 45 +5
Lines 6045 6416 +371
==========================================
+ Hits 5259 5442 +183
- Misses 786 974 +188
|
ilan-gold
force-pushed
the
ig/xarray_compat
branch
from
68fcd2b
to
6165f07
Compare
|
Discussion point: creating dummy indices to speed up first-load time. The real index will simply be stored in |
ilan-gold
commented
Sep 30, 2024
Comment on lines
+730
to
+737
| if any( | ||
| isinstance(el, (sparse.spmatrix, SpArray)) | ||
| or ( | ||
| isinstance(el, DaskArray) | ||
| and isinstance(el._meta, (sparse.spmatrix, SpArray)) | ||
| ) | ||
| for el in els | ||
| ): |
There was a problem hiding this comment.
A bug @ivirshup or @flying-sheep? Needs its own PR? This was spitting out NaNs before for dask-sparse
ilan-gold
changed the title
xarray with experimental backed readingread_lazy for xarray reading + read_elem_as_dask -> read_lazy_elem
ilan-gold
changed the title
read_lazy for xarray reading + read_elem_as_dask -> read_lazy_elemread_lazy for xarray reading + read_elem_as_dask -> read_elem_lazy
Done, tested, with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a lighter weight version of #947 that involves using the original
AnnDataobject as the class to holdobsandvarxr.Dataset..obsand.varwithbacked="r"mode #981