Add docs about Webpack Encore. #120
Conversation
bellisk
force-pushed
the
hackday-introduce-webpack-encore
branch
2 times, most recently
from
79d41d6
to
3c03de0
Compare
|
|
||
| The app's main CSS file should be `source/assets/css/app.css`. | ||
| You can add more CSS files in the same directory if necessary and require them | ||
| in your JavaScript files to use them. |
There was a problem hiding this comment.
why javascript files? "... and require them in your app.css file to make them included."?
There was a problem hiding this comment.
You can do it that way, but the preferred way is really to require them in your javascript files. (It's also possible to add CSS files to webpack.config.js by themselves, but again, not preferred. https://symfony.com/doc/current/frontend/encore/simple-example.html#compiling-only-a-css-file)
There was a problem hiding this comment.
so the css is embedded in javascript? isn't that bad for page loading performance? or how should i understand "require"?
| The [Blog Skeleton](https://github.com/sculpin/sculpin-blog-skeleton) project | ||
| uses Encore to manage assets. If you're setting up your project with Sculpin | ||
| directly, not using the skeleton, install Encore using the | ||
| [setup instructions](https://symfony.com/doc/current/frontend/encore/installation.html). |
There was a problem hiding this comment.
i'd add one more paragraph here saying that you need to install yarn and link to https://yarnpkg.com/en/docs/install for installation instructions
There was a problem hiding this comment.
I'm not sure that's necessary, as the Encore instructions start off by telling you to install Node and Yarn, and link to the installation docs for both.
There was a problem hiding this comment.
The sculpin-blog-skeleton README mentions using yarn to install the JS dependencies, but doesn't talk about installing yarn itself. I think if we are going to mention that anywhere, it should be in that README. @dbu maybe you could add that to sculpin/sculpin-blog-skeleton#61 ?
There was a problem hiding this comment.
🤦♂️ Oh, you included that in sculpin/sculpin-blog-skeleton#61 already, sorry. I still don't think it's necessary to note it separately here.
bellisk
force-pushed
the
hackday-introduce-webpack-encore
branch
from
3c03de0
to
7083b71
Compare
No description provided.