Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_date period separator support #963

Draft
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

gavishpoddar
Copy link
Contributor

@gavishpoddar gavishpoddar commented Aug 13, 2021

This PR solves the below issues, it adds support for date objects like 12.12.2000 (separated by .)

Tests are added for these cases

Thanks and Pl suggest if changes are required

Originally from #963

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #963 (b54890e) into master (507dc6d) will decrease coverage by 0.18%.
The diff coverage is 96.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
- Coverage   98.29%   98.10%   -0.19%     
==========================================
  Files         234      235       +1     
  Lines        2694     2698       +4     
==========================================
- Hits         2648     2647       -1     
- Misses         46       51       +5     
Impacted Files Coverage Δ
dateparser/search/search.py 94.73% <94.33%> (-4.64%) ⬇️
dateparser/languages/locale.py 98.71% <100.00%> (+0.02%) ⬆️
dateparser/search/__init__.py 100.00% <100.00%> (ø)
dateparser/search/languages.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507dc6d...b54890e. Read the comment docs.

@gavishpoddar
Copy link
Contributor Author

This PR is currently broken

@gavishpoddar gavishpoddar marked this pull request as draft October 11, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant