Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add support for 2.13.15 #641

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: add support for 2.13.15 #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae6baf0
chore: add support for 2.13.15
ckipp01 Sep 23, 2024
b0dd29d
fix: ignore for loop guard test
ckipp01 Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ jobs:
{ version: '2.12.20' },
{ version: '2.12.19' },
{ version: '2.12.18' },
{ version: '2.13.15' },
{ version: '2.13.14' },
{ version: '2.13.13' },
{ version: '2.13.12' }
{ version: '2.13.13' }
]
steps:
- name: checkout the repo
Expand Down
1 change: 1 addition & 0 deletions bin/test-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ coursier fetch \
org.scoverage:scalac-scoverage-plugin_2.13.12:$version \
org.scoverage:scalac-scoverage-plugin_2.13.13:$version \
org.scoverage:scalac-scoverage-plugin_2.13.14:$version \
org.scoverage:scalac-scoverage-plugin_2.13.15:$version \
org.scoverage:scalac-scoverage-runtime_2.12:$version \
org.scoverage:scalac-scoverage-runtime_2.13:$version \
org.scoverage:scalac-scoverage-runtime_sjs1_2.12:$version \
Expand Down
3 changes: 2 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import sbtcrossproject.CrossType
lazy val munitVersion = "1.0.2"
lazy val scalametaVersion = "4.9.9"
lazy val defaultScala212 = "2.12.20"
lazy val defaultScala213 = "2.13.14"
lazy val defaultScala213 = "2.13.15"
lazy val defaultScala3 = "3.3.0"
lazy val bin212 =
Seq(
Expand All @@ -17,6 +17,7 @@ lazy val bin212 =
lazy val bin213 =
Seq(
defaultScala213,
"2.13.14",
"2.13.13",
"2.13.12",
"2.13.11"
Expand Down
9 changes: 8 additions & 1 deletion plugin/src/test/scala/scoverage/PluginCoverageTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,14 @@ class PluginCoverageTest extends FunSuite with MacroSupport {
compiler.assertNMeasuredStatements(2)
}

test("scoverage should instrument for-loop guards") {
// We ignore here becuase we end up getting an error in the compiler.
// ```
// scala.reflect.internal.Positions$ValidateException: Enclosing tree [165] does not include tree [160]
// ```
// When you do have this code it doesn't seem to actually impact the coverage data that is generated
// so we just made note of this and ignored it. You can see more of the conversation in:
// https://github.com/scoverage/scalac-scoverage-plugin/pull/641
test("scoverage should instrument for-loop guards".ignore) {
val compiler = ScoverageCompiler.default

compiler.compileCodeSnippet(
Expand Down