Properly handle multiple exclude entries for Scala 3 #548
Conversation
|
@ckipp01 @rolandtritsch please check this out, should be quick |
| @@ -4,7 +4,7 @@ scalaVersion := "3.4.2" | |||
|
|
|||
| libraryDependencies += "org.scalameta" %% "munit" % "0.7.29" % Test | |||
|
|
|||
| coverageExcludedFiles := ".*/two/GoodCoverage" | |||
| coverageExcludedFiles := ".*/two/GoodCoverage;.*/three/GoodCoverage" | |||
There was a problem hiding this comment.
Do the forward slashes need to be escaped like this ... ???
coverageExcludedFiles := ".*\\/two\\/GoodCoverage;.*\\/three\\/.*"There was a problem hiding this comment.
Hey, not sure about slashes. I believe it works as is on Linux which is proven by tests. But maybe you would want to add a windows environment for the checks and we can see if tests pass.
And thanks for checking the PR!
Hi @jozic. Sorry. Just seeing this now. Thanks for the fix. One quick question/comment. Otherwise it looks good. |
|
Hi @jozic. Was just testing this (more). Found one (small) problem, where the test file is missing some tests. Will merge the fix first. Will improve the test files in a seperate PR. Thanks for the fix. |
|
Hi @jozic. Just released v2.1.1 - https://github.com/scoverage/sbt-scoverage/releases/tag/v2.1.1 |
Closes #542