Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support file and package exclusions for Scala 3.4.2+ #541

Merged

Conversation

jozic
Copy link
Contributor

@jozic jozic commented Jun 19, 2024

fixes #525

@jozic jozic marked this pull request as ready for review June 19, 2024 22:16
@jozic
Copy link
Contributor Author

jozic commented Jun 19, 2024

@ckipp01 please review when you have a minute

@TonioGela
Copy link

+1 on this

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @jozic! I left a nit, but it's not a huge deal, probably helpful for us to track in the future. I'll go ahead and merge now and then cut a release.

@@ -104,6 +103,8 @@ You can also mark sections of code with comments like:
Any code between two such comments will not be instrumented or included in the
coverage report.

Note: Comments exclusion works only for Scala2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: Comments exclusion works only for Scala2.
Note: Comment exclusion works only for Scala2.

Also, if there is an issue for this in the Scala 3 issue tracker can we link it here?

@ckipp01 ckipp01 merged commit 76a39fb into scoverage:main Jul 1, 2024
3 checks passed
@jozic jozic deleted the support-excluded-files-and-packages-for-scala3 branch July 1, 2024 18:36
@ckipp01
Copy link
Member

ckipp01 commented Jul 3, 2024

Sorry had an issue with the release due to some sonatype changes, but everything should be good to go now and released 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package / file exclusion does not work with Scala 3
3 participants