Could io.github.scouter-project:scouter-webapp:2.17.1 drop off redundant dependencies? #869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I found the pom file of project io.github.scouter-project:scouter-webapp:2.17.1 introduced 88 dependencies. However, among them, 7 libraries (7%) are not used by your project. I list the redundant dependencies below:
Redundant dependencies
org.glassfish.web:javax.el:jar:2.2.4:compile
javax.xml.bind:jaxb-api:jar:2.3.0:compile
javax.activation:activation:jar:1.1.1:compile
javax.annotation:javax.annotation-api:jar:1.2:compile
javax.inject:javax.inject:jar:1:compile
com.sun.xml.bind:jaxb-impl:jar:2.3.0:compile
javax.el:javax.el-api:jar:2.2.4:compile
Outdated dependencies
javax.inject:javax.inject:1 (5037 days without maintenance)
javax.annotation:javax.annotation-api:1.2 (3746 days without maintenance)
javax.activation:activation:1.1.1 (5027 days without maintenance)
com.sun.xml.bind:jaxb-impl:2.3.0 (2188 days without maintenance)
Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, one of the redundant dependencies javax.annotation:javax.annotation-api:jar:1.2:compile induced dependency conflict in the dependency graph. As such, I suggest a refactoring operation for io.github.scouter-project:scouter-webapp:2.17.1’s pom file.
The attached PR helps resolve the reported problem. It is safe to remove the unused libraries (we considered Java reflection relations when analyzing the dependencies). These changes have passed io.github.scouter-project:scouter-webapp:2.17.1’s maven tests.
Best regards