feat(feh): deassociate with xcf, pdf, dvi, txt #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of feh 3.10, some formats are handled by feh out-of-the-box
(by the Imlib2 library), and some other formats can be opened by
providing the option `--conversion-timeout` which falls back to
ImageMagick’s `convert` utility.
- opening *.svg works out-of-the-box;
- opening *.svgz works through ImageMagick;
- opening *.xcf (Gimp vectorial image) is mentioned in feh’s manpage
but I have been unable to open any such file;
- I could not test *.cdr (CorelDRAW vectorial image)
but I would doubt it works better than *.xcf;
- opening *.otf, *.ttf (font files) works through ImageMagick;
- opening *.eps works through ImageMagick;
- opening *.ps, *.pdf, *.dvi (document files) works through ImageMagick,
but only when the document contains a single page;
+ PDF and DVI are primarily used for possibly-multipage textual
documents, PDF viewers are widely available and they are much better
for this purpose than an image viewer that first converts documents
to bitmaps; it’s unlikely that a user wants to use feh for these.
+ PS, albeit similar in function to PDF, is often used for single-page
graphics such as logos; EPS is a restriction of PS to only one page.
- opening *.txt does not work and makes no sense.
Hence the rationale for not suggesting *.xcf, *.pdf, *.dvi, *.txt .
*.cdr may also be removed if one is able to try it first.
It’s not uncommon to have homonym files side by side, differing only by
extension, *.jpg and *.pdf (e.g. scanned documents) or *.png and *.xcf
(rendered image and work-in-progress design with Gimp).
This is a partial revert of 63574c8 (from 12 years ago).
What is the problem in this case? According to the man page, it seems to use ImageMagick for
Is it? The images that will be embedded in PDFs are usually generated as single-page PDFs. I always create plots in academic papers as single-page PDFs. Although I'm not a user of |
|
I have not tested the behavior, but I'm inclined to agree with @akinomyoga here, unless some more feedback confirming that deassociating these would be the right thing to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message.