Use Slack webhook instead of API token #381
Open
+300
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll test this and let you know |
|
This might be quite a widely used integration so it might be worth considering making this backwards compatible |
|
Hi, sorry for my late reply, I was very busy. I have reverted my changes to keep the slack integration with the API token for backward compatibility and re-added the webhook support. Hope this is better now ! |
|
any update on merging this? also +1 on using message attachments. that would make the alerts in slack much more readable. |
|
Personally, I'd rather see SLACK_WEBHOOK_URL override SLACK_TOKEN and not the other way around. |
Closed
|
I built on this branch and opened up #423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #376. We may change the message using slack attachment though.