add change handling for props #146
Conversation
|
@andyrichardson I am a lot shorter on time these days as when I started this project. Codemirror & React APIs are moving to quickly for me to keep atop of for the day-to-day. I am looking for a co-maintainer of this project. Please contact me directly if you are interested. Thank you for understanding. |
| import * as React from 'react'; | ||
| import * as codemirror from 'codemirror'; | ||
| import {Position} from "codemirror"; | ||
| import * as React from "react"; |
There was a problem hiding this comment.
Hey @andyrichardson - I'm going to help to get this merged if you're still up for it?
Soo... I don't see anything in the .editorconfig file that defines the spacing / quotes style for this project but your change introduces a number of purely stylistic changes that I think are ancillary. I personally like the style you're using but I don't want to mix/match. Would you be up for either a) removing stylistic changes b) committing changes to .editorconfig to either cause your style or the original one to be applied throughout?
There was a problem hiding this comment.
Hey @elsigh I'm more than happy to go with whatever stylistic preferences the project has! Sorry about the unnecessary changes, I have prettier on by default which goes HAM on everything.
There was a problem hiding this comment.
@andyrichardson - I had the same issue - I had to use Cmd-Shift-P to save without formatting.
There was a problem hiding this comment.
Gentle ping @andyrichardson =)
There was a problem hiding this comment.
I will sort this out this week!
I hope... 😉
There was a problem hiding this comment.
Would still love to merge this one if you get a little time
There was a problem hiding this comment.
Would love to see this merged still if possible! @andyrichardson
Fix #142