VVT: EFA-based provider #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially reverts ea0865f, updates the endpoint URL, renames the class and fixes the tests (the station ids changed from 604xxxxx to 601xxxxx). This endpoint is officially used by VVT to generate PDF timetables; the domain points to a VVT (not VAO) owned IP/server.
|
I wonder how much future has this provider got? What's the data quality, compared to their Hafas/VAO-backed API? Is the EFA API used by any of their own frontends/apps? |
|
On Sat, Jun 27, 2020 at 12:35:10AM -0700, Andreas Schildbach wrote:
I wonder how much future has this provider got?
I don't think that API will get removed very soon, but of course there's
no knowning.
What's the data quality, compared to their Hafas/VAO-backed API?
No realtime data, otherwise not bad. I can't currently compare with VAO,
since Transportr raises an AUTH runtimeexception (opening ticket in a
second), but it looks like it's all there.
Is the EFA API used by any of their own frontends/apps?
yes, for creating pdfs of time tables. here is an example:
https://vvt.at/page.cfm?vpath=fahrplan/linienfahrplan&stop_id=60101187&line=ivb:01002:P:R:j20&i=Innsbruck%2C%20Hauptbahnhof%20%E2%80%93%20Tram%202
sneaky edit: runtimeexception-ticket: #314
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled upon this endpoint today. It would be a suitable replacement for Innsbruck/IVB (#183). This API is provided by VVT themselves, not through VAO, who according to @schildbach are opposing the use of "their" data, so this may be a possibility to get VVT back into Öffi. (the domain points directly to a VVT-owned IP, not to VAO)
The API only returns results for Tirol, meaning suggestions will be better than those provided by OebbProvider or the VAO based VvtProvider.
I wasn't sure if it's appropriate to replace the current
VvtProvider(the blacklisted VAO one, which returns the same results as VaoProvider), so I called itVvtEfaProvider. Also, I added my name to the VvtEfa* files, but I doubt my changes are even significant enough to be copyrightable, so I have no problem to remove the mention.Also pinging @grote, since I'd love to see this in Transportr.
Commit message: