HSL: Fixed UnexpectedRedirectException related to incorrect API URL

[msjoberg]

This commit fixes bug #313 reported for Transportr. When running the HslProvider tests I also noticed another bug which I fixed.

[grote]

Thanks, looks good to me! :)

[schildbach]

Thanks! I had a slightly different fix on my master already. Can you look at 1b10571 and see if that fixes it for you too?

[msjoberg]

@schildbach Hi, it's fixes one of the issues but not the other that I can see by running the HslProviderLiveTest:

	at com.google.common.base.Preconditions.checkArgument(Preconditions.java:122)
	at de.schildbach.pte.dto.Location.<init>(Location.java:60)
	at de.schildbach.pte.dto.Location.<init>(Location.java:69)
	at de.schildbach.pte.dto.Location.<init>(Location.java:83)
	at de.schildbach.pte.HslProvider$3.onSuccessful(HslProvider.java:309)

You can see my fix for that here: https://github.com/schildbach/public-transport-enabler/pull/143/files#diff-f497cad9ef4e87811b6eff2ec1154ce2L309

[schildbach]

Can you rebase on current master and describe what the remaining change is fixing exactly? I don't see how this is related to the base URL problem (redirect).

[msjoberg]

You're right: it's not related to the URL problem. It's described in the commit message, but not the pull request - sorry!

new Location throws an IllegalArgumentException without that change. It's such a trivial fix that it would perhaps be easier if you just did the change directly?