Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #252

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fuchsst
Copy link
Contributor

@fuchsst fuchsst commented Mar 29, 2022

pure code cleanup

  • remove unused imports
  • replace * imports with explicit package names
  • alphabetical reorderd imports
    this MR is based on MR #251

@larsga
Copy link
Collaborator

larsga commented Apr 6, 2022

Removing unused imports is great, but the rest amounts to a change in code style. Can we limit this to just the unused imports, please?

@fuchsst
Copy link
Contributor Author

fuchsst commented Apr 9, 2022

Removing unused imports is great, but the rest amounts to a change in code style. Can we limit this to just the unused imports, please?

i used intellij's Optimize Imports - removed the implicit changes (e.g. rearangements of the imports) now

maybe some gradle plugin like Checkstyle would make sense to enforce a common code style?
IntelliJ can be configured to refer to the same style-config, so Strg+Alt+L (or Strg-Alt-O) will arrange the code the same.
Or, more general, one can add a pre-commit-hook to apply the checkstyle autofix on changed files.

@larsga
Copy link
Collaborator

larsga commented Apr 12, 2022

This PR still has more than just removing unused imports. I don't think this is very important, so perhaps better to skip it rather than put a lot of effort into it? I would have removed the unused imports myself if I thought it was important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants