Three seconds is better #1456
Open
Three seconds is better #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink.ino
Outdated
| @@ -18,7 +18,7 @@ void setup() { | |||
| // the loop routine runs over and over again forever: | |||
| void loop() { | |||
| digitalWrite(led, HIGH); // turn the LED on (HIGH is the voltage level) | |||
| delay(1000); // wait for a second | |||
| delay(3000); // wait for a second | |||
| digitalWrite(led, LOW); // turn the LED off by making the voltage LOW | |||
| delay(2000); // wait for a second | |||
There was a problem hiding this comment.
Hi Schacon, I believe it would be better if the light was off for 4 seconds and on for just 3.
Change delay to 3 seconds and 4 seconds repectively
|
This PR will increase the LED delay. In this code I have modified some part so that light was off for 4 seconds and on for just 3.
|
Merge pull request #1 from aniketdas-tiger-analytics/slow-blink
for(int i=0 ; i < 5 ; i++)
{
System.out.println("i is : " + i);
} |
for i in range(1,20):
if i%2==0:
print(i)
else:
print("ODD") |
How big are these slings and in particular, these arrows? 😂 🐼 |
|
@aniketdas-tiger-analytics is the one who made those above comments. |
|
Hello I am Aniket Das. I am commenting through Github API in a Pull Request which I have raised on my own, 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Studies have shown that 3 seconds is a far better LED delay than 1 second.
https://www.nngroup.com/articles/response-times-3-important-limits/
You should also see #1326