-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(key-manager): add a page explaining the difference between secret manager and key manager #3648
Open
enzzc
wants to merge
4
commits into
scaleway:main
Choose a base branch
from
enzzc:int-feat-key-manager-docs-diff-sm-km
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerda-codes
added
the
do not merge
PR that shouldn't be merged before a specific date (eg release)
label
Aug 28, 2024
RoRoJ
reviewed
Sep 2, 2024
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
...agement/key-manager/reference-content/differences-between-secret-manager-and-key-manager.mdx
Outdated
Show resolved
Hide resolved
Thanks for the review @RoRoJ , I'm fine with your suggestions 👍 |
Co-authored-by: Rowena Jones <[email protected]>
bene2k1
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.