Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate regex patterns to jvm-only directory in preparation for Scala Native #4309

Merged

Conversation

jchyb
Copy link
Contributor

@jchyb jchyb commented Sep 23, 2024

Part of the Scala Native cross compilation effort (#4279)

@jchyb jchyb changed the title Separate regex patterns to jam-only object in preparation for Scala Native Separate regex patterns to jvm-only object in preparation for Scala Native Sep 23, 2024
@jchyb jchyb changed the title Separate regex patterns to jvm-only object in preparation for Scala Native Separate regex patterns to jvm-only directory in preparation for Scala Native Sep 23, 2024
@jchyb jchyb force-pushed the scala-native/separate-regex-patterns branch from fb82d72 to 8e188e2 Compare September 23, 2024 10:43
@jchyb jchyb marked this pull request as ready for review September 23, 2024 11:10
Copy link
Collaborator

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did i have two different implementations of matching strip margin?

@kitbellew kitbellew merged commit c985670 into scalameta:main Sep 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants