Interfaces: add credentials to public interface #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Aug 28, 2023
| public final String host; | ||
| public final String username; | ||
| public final String password; | ||
| public final String realm; |
There was a problem hiding this comment.
realm doesn't seem to be used, do we need it?
There was a problem hiding this comment.
it's not used in the current implementation, because we pass before the connection. if we figure out how to pass all of credentials, possibly if coursier changes the interface and allows passing them via API rather than coursier.credentials java system property, that will change.
is adding a realm later going to be a breaking binary change?
There was a problem hiding this comment.
With a default value it shouldn't.
There was a problem hiding this comment.
in that case, removing realm for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will presumably help solve scalameta/sbt-scalafmt#108.