Refactor TransformerConfiguration Paths to more explicitly trace what is matched on source-side and what on target-side #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is matched on source-side and what on target-side
MateuszKubuszok
commented
Oct 2, 2024
| def unapply(path: Path): Option[(??, Path)] = | ||
| path.segments.headOption.collect { case Segment.SourceMatching(tpe) => tpe -> new Path(path.segments.tail) } | ||
| } | ||
|
|
There was a problem hiding this comment.
This special-case hack is no longer needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
+ Coverage 86.56% 86.79% +0.23%
==========================================
Files 155 155
Lines 6012 6012
Branches 542 544 +2
==========================================
+ Hits 5204 5218 +14
+ Misses 808 794 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MateuszKubuszok
commented
Oct 2, 2024
| @@ -585,7 +609,7 @@ private[compiletime] trait Configurations { this: Derivation => | |||
| extractPath[PathType2].matching[Subtype] | |||
| case ChimneyType.Path.SourceMatching(init, sourceSubtype) => | |||
There was a problem hiding this comment.
We have to leave this in the DSL runtime (bincompat), so we might as well still parse it.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #248 and #611