Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
contramap
andmap
ops to theTransformer
andPartialTransformer
#591base: master
Are you sure you want to change the base?
Add
contramap
andmap
ops to theTransformer
andPartialTransformer
#591Changes from 5 commits
4cee372
c166654
ac9126e
2610f54
787e122
a3eb1c3
638901f
4008c52
64c486c
b6882c6
0733e9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is
map
in partial, there could also bemapPartial[A](f: To => partial.Result[A]): PartialTransformer[From, A]
.Since
Transformer
hascontramap
thePartialTransformer
should also get one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this once again and don't see any issue with adding
contramap
toPartialTransformer
andmap
toTransformer
, respectively.What about
mapPartial
, it might be useful indeed, but don't you mind if we would add it separately?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
PartialTransformer
hasmap
theTransformer
should also get one.