Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final update to SIP-27 Trailing Commas #731

Merged
merged 3 commits into from
Mar 30, 2017
Merged

Final update to SIP-27 Trailing Commas #731

merged 3 commits into from
Mar 30, 2017

Conversation

dwijnand
Copy link
Member

No description provided.

@dwijnand
Copy link
Member Author

dwijnand commented Mar 15, 2017 •
edited
Loading

Part of the checklist for fixing scala/scala-dev#299.

@adriaanm adriaanm mentioned this pull request Mar 15, 2017
Closed
5 tasks
@SethTisue SethTisue requested a review from jvican March 29, 2017 23:03
jvican
jvican approved these changes Mar 30, 2017
View reviewed changes
Copy link
Member

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvican jvican merged commit a049f92 into scala:master Mar 30, 2017
@dwijnand dwijnand deleted the trailing-commas-sip-update branch March 30, 2017 07:47
@dwijnand
Copy link
Member Author

Thank you, Jorge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvican jvican jvican approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwijnand @jvican