Fix multi-platform builds with multiple aliases. #1651
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-platform builds append a
-t
argument for each alias to thedockerBuildOptions
, but thepublishTask
function was ALWAYS iterating over the aliases even if it was a multi-platform build.sbt-native-packager/src/main/scala/com/typesafe/sbt/packager/docker/DockerPlugin.scala
Lines 157 to 159 in 7c68859
The consequence was attempts to buildx and push the tags multiple times. In some environments this leads to build failures because you can't push the same tag twice.
This change simply does not iterate over the aliases for multiplatform builds.
Note: using
dockerUpdateLatest := true
counts as having multiple aliases, which is how I encountered this bug.