Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarder script is added to AshScriptPlugin #1557

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

Seetaramayya
Copy link
Contributor

@lightbend-cla-validator

Hi @Seetaramayya,

Thank you for your contribution! We really value the time you've taken to put this together.

We see that you have signed the Lightbend Contributors License Agreement before, however, the CLA has changed since you last signed it.
Please review the new CLA and sign it before we proceed with reviewing this pull request:

http://www.lightbend.com/contribute/cla

muuki88
muuki88 previously approved these changes Dec 19, 2023
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. LGTM.

You only need to add the MIMA problem filters to this file:
https://github.com/sbt/sbt-native-packager/blob/master/src/main/mima-filters/1.3.15.backward.excludes

You can find the error in the github action output

@Seetaramayya
Copy link
Contributor Author

Seetaramayya commented Dec 22, 2023

I hope force push is not causing dismissing of stale review ( I rebased on to the master so I have to force push )
image

@Seetaramayya Seetaramayya mentioned this pull request Dec 23, 2023
@muuki88 muuki88 merged commit 6ccddfc into sbt:master Jul 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants