Fixes for argument handling in AshScriptPlugin's script template #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `custom_mainclass` variable was set but never used. `process_args` is called after `app_mainclass` is set to the default value, so this can simply overwrite the variable.
This matches the behavior of the Bash template and allows overriding config file options on the command line.
|
Hi @kevinmehall, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Hi @kevinmehall, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Can you sign the Contributor CLA? |
|
Hi @kevinmehall, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-mainargument was ignored because thecustom_mainclassvariable was set but never used.process_argsis called afterapp_mainclassis set to the default value, so this PR makes it simply overwriteapp_mainclassinstead of introducing another variable.javabefore the defaults, which means the defaults take precedence and couldn't be overridden. This puts the flags fromJAVA_OPTSand the command line after the defaults, which matches the behavior of the Bash template.