Skip to content

feat(plasma-icons): Add icons for 24 dp from F to M #1165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(plasma-icons): Add icons for 24 dp from F to M #1165

wants to merge 2 commits into from

Conversation

neretin-trike
Copy link
Contributor

@neretin-trike neretin-trike commented Mar 29, 2022 •
edited by SberDevices-Eva
Loading

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @sberdevices/demo-canvas-app@0.68.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-b2c@1.54.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-icons@1.73.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-temple@1.48.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-ui@1.91.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-web@1.89.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/showcase@0.110.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-temple-docs@0.13.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-ui-docs@0.59.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-web-docs@0.47.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
npm install @sberdevices/plasma-website@0.44.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
# or 
yarn add @sberdevices/demo-canvas-app@0.68.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-b2c@1.54.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-icons@1.73.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-temple@1.48.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-ui@1.91.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-web@1.89.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/showcase@0.110.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-temple-docs@0.13.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-ui-docs@0.59.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-web-docs@0.47.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0
yarn add @sberdevices/plasma-website@0.44.0-canary.1165.d4da253130216c8f89cac689f54584ab3f763a43.0

@neretin-trike neretin-trike requested a review from OgNellis as a code owner March 29, 2022 09:31
@neretin-trike neretin-trike changed the title feat(plasma-icons): feat(plasma-icons): Add icons for 24 dp from F to M feat(plasma-icons): Add icons for 24 dp from F to M Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #1165 (969c788) into master (e6b77fc) will increase coverage by 0.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
+ Coverage   89.06%   89.52%   +0.45%     
==========================================
  Files         433      414      -19     
  Lines        5891     5574     -317     
  Branches     1693     1611      -82     
==========================================
- Hits         5247     4990     -257     
+ Misses        643      583      -60     
  Partials        1        1
Flag Coverage Δ
plasma-b2c 95.86% <ø> (ø)
plasma-core 94.95% <ø> (ø)
plasma-temple 82.45% <ø> (+0.15%) ⬆️
plasma-ui 94.42% <ø> (ø)
plasma-web 96.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/plasma-temple/src/utils/scroll.ts 0.00% <0.00%> (-82.36%) ⬇️
...age/components/ItemMainSection/ItemMainSection.tsx 70.58% <0.00%> (-19.42%) ⬇️
.../src/components/StateLayout/[email protected] 94.73% <0.00%> (-5.27%) ⬇️
...ages/plasma-temple/src/pages/ItemPage/ItemPage.tsx 85.18% <0.00%> (ø)
...ges/plasma-temple/src/registry/[email protected] 100.00% <0.00%> (ø)
...es/plasma-temple/src/pages/ErrorPage/ErrorPage.tsx 100.00% <0.00%> (ø)
.../plasma-temple/src/registry/[email protected] 100.00% <0.00%> (ø)
...-temple/src/pages/GridPage/components/GridCard.tsx 100.00% <0.00%> (ø)
.../src/components/StateLayout/[email protected] 100.00% <0.00%> (ø)
...src/components/StateLayout/[email protected] 100.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a4370...969c788. Read the comment docs.

@neretin-trike neretin-trike force-pushed the icon-export-h7ndpjo7sv8 branch from 60eacd9 to 7e4f140 Compare March 29, 2022 10:06
@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1165/

@SberDevices-Eva
Copy link
Collaborator

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1165/
ui storybook: http://plasma.sberdevices.ru/pr-1165/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1165/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1165/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1165/temple-storybook/

@neretin-trike neretin-trike force-pushed the icon-export-h7ndpjo7sv8 branch from 7e4f140 to 969c788 Compare March 30, 2022 13:14
@SberDevices-Eva
Copy link
Collaborator

Demo canvas app deployed!

http://plasma.sberdevices.ru/demo-canvas-app-pr-1165/

@SberDevices-Eva
Copy link
Collaborator

Documentation preview deployed!

website: http://plasma.sberdevices.ru/pr-1165/
ui storybook: http://plasma.sberdevices.ru/pr-1165/ui-storybook/
web storybook: http://plasma.sberdevices.ru/pr-1165/web-storybook/
b2c storybook: http://plasma.sberdevices.ru/pr-1165/b2c-storybook/
temple storybook: http://plasma.sberdevices.ru/pr-1165/temple-storybook/

Yeti-or
Yeti-or reviewed Apr 12, 2022
View reviewed changes
packages/plasma-icons/src/scalable/Icon.assets.24/Click.tsx
/>
<path
fillRule="evenodd"
clipRule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both

packages/plasma-icons/src/scalable/Icon.assets.24/Click.tsx
<path
opacity="0.6"
fillRule="evenodd"
clipRule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both

packages/plasma-icons/src/scalable/Icon.assets.24/Dislike.tsx

export const Dislike: React.FC<IconProps> = (props) => (
<svg width="100%" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<g style={{ mixBlendMode: 'lighten' }}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не нужен

packages/plasma-icons/src/scalable/Icon.assets.24/Dislike.tsx
/>
<path
fillRule="evenodd"
clipRule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

только clip

packages/plasma-icons/src/scalable/Icon.assets.24/DotsHorizontalOutline.tsx
<svg width="100%" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<path
fillRule="evenodd"
clipRule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both

packages/plasma-icons/src/scalable/Icon.assets.24/MoviesFill.tsx
<clipPath id="clip078531569">
<rect width="24" height="24" fill="currentColor" />
</clipPath>
</defs>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

убрать

packages/plasma-icons/src/scalable/Icon.assets.24/MusicAlbumFill.tsx
fill="currentColor"
/>
<path
fillRule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both

packages/plasma-icons/src/scalable/Icon.assets.24/MusicFill.tsx

import { IconProps } from '../IconRoot';

export const MusicFill: React.FC<IconProps> = (props) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

точно fill ?

packages/plasma-icons/src/scalable/Icon.assets.24/MusicFill.tsx
<svg width="100%" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<path
fillRule="evenodd"
clipRule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both

packages/plasma-icons/src/scalable/Icon.assets.24/MusicMicFill.tsx
<svg width="100%" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}>
<path
fillRule="evenodd"
clipRule="evenodd"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yeti-or Yeti-or Yeti-or left review comments

@OgNellis OgNellis Awaiting requested review from OgNellis

@fanisco fanisco Awaiting requested review from fanisco

@LamaEats LamaEats Awaiting requested review from LamaEats

@kvpolyanskiy kvpolyanskiy Awaiting requested review from kvpolyanskiy

@VladislavPetyukevich VladislavPetyukevich Awaiting requested review from VladislavPetyukevich

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
v2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neretin-trike @SberDevices-Eva @Yeti-or