Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expample with unpack and subscr #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steffen19w23
Copy link

No description provided.

@steffen19w23
Copy link
Author

see #197

@nifadyev
Copy link
Contributor

Hey @steffen19w23 , are you still interested in merging this PR into main? The explanation looks quite difficult to understand, mostly because of disassembled code. Few of users can read it. Could you make it more reader-friendly?

@steffen19w23
Copy link
Author

Want to merge into main. Don't blame me that non-trivial behaviour can only explained in non-trivial manner.

@nifadyev
Copy link
Contributor

Sorry if my comment was offended to you, it wasn't meant to be. @satwikkansal also mentioned difficulties with understanding the snippet in issue's comment.

So it is advised to try to simplify or rephrase the explanation a bit. If it is hard to do, we can suggest some changes in explanation.

Could you also check the snippet on relevant python versions (3.9 - 3.13)? The easiest way to do so is to checkout to this branch, create a virtual environment, install dependencies and run nox. These changes are in review and not in main, but nox checks are necessary for new snippets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants