Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep interpolation in var CSS function #250

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

pamelalozano16
Copy link
Contributor

Bug fix: Keep interpolation within var() functions.

Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also want to merge/rebase this on top of main, as I needed to make some changes to make this compatible with the latest sass_api

lib/src/migrators/calc_interpolation.dart Outdated Show resolved Hide resolved
lib/src/migrators/calc_interpolation.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
lib/src/migrators/calc_interpolation.dart Outdated Show resolved Hide resolved
lib/src/migrators/calc_interpolation.dart Outdated Show resolved Hide resolved
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in the pubspec also needs to be bumped to 2.0.1, otherwise this LGTM

@jathak jathak merged commit 6d08f6d into sass:main Jan 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants