Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BooleanExpression and NumberExpression to sass-parser #2376

Merged
merged 12 commits into from
Oct 18, 2024
Merged

Conversation

Goodwine
Copy link
Member

@Goodwine Goodwine commented Oct 3, 2024

No description provided.

@Goodwine Goodwine force-pushed the boolean-expr branch 2 times, most recently from 560cb04 to 4f1d4ae Compare October 16, 2024 22:46
@Goodwine Goodwine requested a review from nex3 October 16, 2024 22:54
@@ -1,6 +1,6 @@
## 0.2.6

* No user-visible changes.
* Add `BooleanExpression` and `NumberExpression`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update this to 0.2.7 if this version has already come out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just cut a release for it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating all three in tandem can be confusing 😅 - I wonder if we could find a way to more easily update these

@@ -1,6 +1,6 @@
## 0.2.6

* No user-visible changes.
* Add `BooleanExpression` and `NumberExpression`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just cut a release for it.

pkg/sass-parser/lib/src/expression/boolean.test.ts Outdated Show resolved Hide resolved
pkg/sass-parser/lib/src/expression/boolean.test.ts Outdated Show resolved Hide resolved
pkg/sass-parser/lib/src/expression/number.ts Outdated Show resolved Hide resolved
@Goodwine Goodwine force-pushed the boolean-expr branch 2 times, most recently from 7f1910e to 25f8928 Compare October 18, 2024 22:47
@Goodwine Goodwine requested a review from nex3 October 18, 2024 22:48
pkg/sass-parser/lib/src/expression/number.test.ts Outdated Show resolved Hide resolved
pkg/sass-parser/lib/src/expression/number.ts Outdated Show resolved Hide resolved
@Goodwine Goodwine merged commit 84e281e into main Oct 18, 2024
38 checks passed
@Goodwine Goodwine deleted the boolean-expr branch October 18, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants