-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update trivy check #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darliiin
requested review from
dmitry-mightydevops,
DanilaKazakevich,
kseniyashaydurova,
MikhailKorol-saritasa,
populov,
roman-mightydevops,
SergeyDeminSaritasa,
udaltsovra,
luciano-buono,
KrawczowaKris and
rtest12
as code owners
November 14, 2024 15:59
dmitry-mightydevops
approved these changes
Nov 14, 2024
MikhailKorol-saritasa
approved these changes
Nov 15, 2024
udaltsovra
approved these changes
Nov 19, 2024
populov
approved these changes
Nov 21, 2024
changelog update? |
rtest12
approved these changes
Nov 22, 2024
KrawczowaKris
approved these changes
Nov 22, 2024
DanilaKazakevich
approved these changes
Nov 25, 2024
@@ -53,16 +53,24 @@ runs: | |||
'{github: {repo: $repo, headRefPush: $headRefPush, headRefPR: $headRefPR, actor: $actor, eventName: $eventName, eventNumber: $eventNumber, commitSha: $commitSha}}' \ | |||
> data.json | |||
|
|||
- name: manual trivy setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't do anything manually here, right?
name it "install trivy"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Task: SD-1026
Trivy
installation moved to a separate step, as in the previous implementation periodicallytrivy
required root access and the check failedsetup-trivy
to install Trivy aquasecurity/trivy-action#406TRIVY_DB_REPOSITORY
since GHCR can impose rate limitsTrivy
action to v0.29.0