Fix: AS3 unchecked mode called 'unsafe' instead of 'unchecked'

sapcc · Jul 31, 2024 · ac6c9b8 · ac6c9b8
1 parent 77f3d97
commit ac6c9b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/octavia_f5/common/config.py b/octavia_f5/common/config.py
@@ -122,8 +122,10 @@ def setup_logging(conf):
                        "Set persist_every < 0, leave the working "
                        "configuration in memory only (if targetHost restart, you may "
                        "lose the configuration from memory")),
-    cfg.BoolOpt('unsafe_mode', default=False,
-                help=_("Use unsafe mode for posting AS3 declarations.")),
+    cfg.BoolOpt('unchecked_mode', default=False,
+                help=_("Use unchecked mode for posting AS3 declarations. The "
+                       "current BigIP state won't be checked when AS3 applies a "
+                       "declaration.")),
     cfg.StrOpt('availability_zone', default=None,
                 help=_("Name of the availability zone the F5 device of this worker is assigned to.")),
     cfg.StrOpt('irule_allowed_cidrs', default='cc_allowed_cidrs',

diff --git a/octavia_f5/restclient/as3restclient.py b/octavia_f5/restclient/as3restclient.py
@@ -156,8 +156,8 @@ def post(self, tenants, payload):
         params = {}
         if CONF.f5_agent.async_mode:
             params['async'] = 'true'
-        if CONF.f5_agent.unsafe_mode:
-            params['unsafe'] = 'true'
+        if CONF.f5_agent.unchecked_mode:
+            params['unchecked'] = 'true'
         return super(AS3RestClient, self).post(url, json=payload.to_dict(), params=params)
 
     @_metric_patch_exceptions.count_exceptions()