Nxos agent config preparations #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently installed version 3.7.9 doesn't seem to have support for the walrus operator := in python3.8, meaning that the pep8 tests fail. Upgrading flake8 to a newer version fixes this.
NXOS portchannels are named something like "po23" and now we can recognize them and parse the port-channel id out of them.
The generic configuration format now has a multisite flag for the VXLANMapping class, which will be set to true for all mappings configured on BGWs. This will be used later on for NXOS BGWs and will be ignored by EOS.
We now allow more than two switches per switchgroup and also allow mixed-vendor switchgroups. We need this for some experimental setups in our qa regions where we want to have certain pairs to be configured in the same way.
sebageek
force-pushed
the
nxos-agent-config-preparations
branch
from
a612f6a
to
cd4202f
Compare
occamshatchet
approved these changes
Aug 19, 2024
mutax
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is everything we need to get the NXOS config rolling for the fabric driver (at least everything I know of) and also supports mixed-vendor switchgroups, so we can act as if multiple EVPN domains are one in our qa landscape. I also included the multisite part, so we'll only need to patch the agent in most cases when we're continuing development on the NXOS agent.