force delete fix #223
Open
force delete fix #223
+84
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carthaca
requested review from
chuan137,
kpawar-sap,
sumitarora2786 and
crenduchinta88
as code owners
Carthaca
force-pushed
the
force_delete_fix
branch
3 times, most recently
from
019252e
to
7b3a601
Compare
chuan137
reviewed
Nov 22, 2024
The force option needs to be a query param. And since we don't have proper error handling for rest api in this release, we use the timeout query to not have to deal with async jobs. Now we apply force delete properly for 2-hour old shares instead of just for 2-minute old ones. Change-Id: Id2fd93d7d6f4d53d788a40243d174fe96be49def
We don't care about the progess percentage. Instead use speaking states for better readability. We are now able to differ the error conditions for clone split: 1. If we want to start clone split: - we need to make sure that volume is a clone (status should not be 'finished') - we want to make sure that clone split it currently not running (status should not be 'ongoing') - therefore we have a status for the remaining cases: 'unknown' 2. If we want to stop clone split: - we need to make sure that volume is a clone (status should not be 'finished') - we want to make sure that clone split is currently running (status should be 'ongoing') Change-Id: I8acaf6ea3c469c053375a15ae73268882fcbda8d
Carthaca
force-pushed
the
force_delete_fix
branch
from
7b3a601
to
06cf21f
Compare
we are missing the request spec to continue creating the share in such cases (e.g. we don't know about the keystone scope and also don't know if maybe a source snapshot_id was provided) Change-Id: Ie0f2fcce4fb64bd043745be014de08fad1e9d95e Co-Authored-By: Chuan Miao <[email protected]>
Carthaca
force-pushed
the
force_delete_fix
branch
from
06cf21f
to
787a290
Compare
|
looks good, will approve after py3 goes green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please have a look at the individual commit messages.
While trying to fix a force-delete bug I needed to reproduce some clone split scenarios and saw some room for improvement there, too.
And the ensure fix is an edge case that happened to me during debugging with lots of manila-share restarts :)