Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow share server migration with replicas #214

Open
wants to merge 1 commit into
base: stable/2023.1-m3
Choose a base branch
from
Open

Allow share server migration with replicas #214

wants to merge 1 commit into from
+121 −4

Conversation

kpawar-sap
Copy link

No description provided.

@kpawar-sap kpawar-sap force-pushed the allow_share_server_migration_with_replicas branch from 0a7726e to 6137fd7 Compare November 4, 2024 11:52
@kpawar-sap
Copy link
Author

fixes https://github.wdf.sap.corp/cc/manila-issues/issues/64

chuan137
chuan137 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@chuan137 chuan137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kpawar-sap
Copy link
Author

upstream has suggested to make changes assuming this config option is global and wont sustain if multiple driver backends are used. So lets hold this change until we finalize there.

@chuan137 chuan137 self-requested a review November 13, 2024 08:31
chuan137
chuan137 requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@chuan137 chuan137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have hard coded disabling the replica check,

manila/manila/share/api.py

Lines 2762 to 2767 in 4af50a0

# if share.has_replicas:
# msg = _('Share %s has replicas. Remove the replicas of all '
# 'shares in the share server before attempting to '
# 'migrate it.') % share['id']
# LOG.warning(msg)
# raise exception.InvalidShareServer(reason=msg)

we can add it back with checking this option now

@chuan137
Copy link
Member

upstream has suggested to make changes assuming this config option is global and wont sustain if multiple driver backends are used. So lets hold this change until we finalize there.

sounds a good idea to use backend capability for this

@kpawar-sap
[netapp] Allow share server migration with replicas
f0e2589 
New share server property `allow_migration_with_replicas` will be set
by share driver and then evaluated in api layer to allow/dis-allow share
server migration with replicas.

Closes-bug: #2052785
Change-Id: I1cc5489488f44cc7edc7348fb3b3af7397564682
@kpawar-sap kpawar-sap force-pushed the allow_share_server_migration_with_replicas branch from 6137fd7 to f0e2589 Compare November 20, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuan137 chuan137 chuan137 requested changes

@Carthaca Carthaca Awaiting requested review from Carthaca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpawar-sap @chuan137