Add test cases to prevent future API breaks on AZ separated changes #636
+148
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoigtS
requested review from
majewsky,
SuperSandro2000 and
Nuckal777
as code owners
majewsky
reviewed
Dec 17, 2024
Comment on lines
12
to
13
| INSERT INTO project_az_resources (id, resource_id, az, quota, usage, physical_usage, subresources) VALUES (1, 1, 'az-one', 5, 1, NULL, ''); | ||
| INSERT INTO project_az_resources (id, resource_id, az, quota, usage, physical_usage, subresources) VALUES (2, 1, 'az-two', 5, 1, NULL, ''); |
There was a problem hiding this comment.
For the complete prototypical example, we would also expect backend_quota to be non-null and equal to quota.
There was a problem hiding this comment.
Thank you for the catch. I included them
majewsky
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in previous PRs. A new fixture was added to cover our existing abstraction levels with one dedicated case.