Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use netapp harvester metrics #631

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use netapp harvester metrics #631

wants to merge 1 commit into from

Conversation

chuan137
Copy link
Member

As part of netapp exporter migration, new metrics will be provided by
netapp harvest exporter.

As part of netapp exporter migration, new metrics will be provided by
netapp harvest exporter.
@chuan137
Copy link
Member Author

diff1 for sharePhysicalUsageQuery
diff2 for snapshotPhysicalUsageQuery

@majewsky
Copy link
Contributor

majewsky commented Dec 16, 2024

Is the netapp-harvester rolled out in all regions?

@chuan137
Copy link
Member Author

yes, harvester is rolled out to production for a while already, so you can try above queries in production too.
fyi, I have already migrated maia to harvester, and the metrics I provided for castellum is also based on it

snapshotPhysicalUsageQuery = `sum by (availability_zone, project_id, share_type) (max by (availability_zone, project_id, share_id, share_type) (last_over_time(netapp_volume_snapshot_used_bytes{project_id!="",share_type!="",volume_type!="dp",volume_state="online"}[15m])))`
snapmirrorUsageQuery = `sum by (availability_zone, project_id, share_type) (max by (availability_zone, project_id, share_id, share_type) (last_over_time(netapp_volume_total_bytes {project_id!="",share_type!="",volume_type!="dp",volume_state="online",snapshot_policy="EC2_Backups"}[15m])))`
snapmirrorPhysicalUsageQuery = `sum by (availability_zone, project_id, share_type) (max by (availability_zone, project_id, share_id, share_type) (last_over_time(netapp_volume_used_bytes {project_id!="",share_type!="",volume_type!="dp",volume_state="online",snapshot_policy="EC2_Backups"}[15m])))`
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This final bracket should stay, belongs to const ( on line 208

@Carthaca
Copy link
Contributor

I was thinking in doing the same approach like we did for castellum in sapcc/helm-charts#5848 and move the logic under the control of the manila team (e.g. there are more updates to the snapmirror metrics in the queue)

But this should better not happen at the same time like the switch from netapp-exporter to harvester metrics.

What do you think? Do we want to first switch to harvester metrics (like proposed in this PR) and then move control over to manila team or the other way around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants