-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use netapp harvester metrics #631
base: master
Are you sure you want to change the base?
Conversation
As part of netapp exporter migration, new metrics will be provided by netapp harvest exporter.
b338cd0
to
f74bf00
Compare
Is the netapp-harvester rolled out in all regions? |
yes, harvester is rolled out to production for a while already, so you can try above queries in production too. |
snapshotPhysicalUsageQuery = `sum by (availability_zone, project_id, share_type) (max by (availability_zone, project_id, share_id, share_type) (last_over_time(netapp_volume_snapshot_used_bytes{project_id!="",share_type!="",volume_type!="dp",volume_state="online"}[15m])))` | ||
snapmirrorUsageQuery = `sum by (availability_zone, project_id, share_type) (max by (availability_zone, project_id, share_id, share_type) (last_over_time(netapp_volume_total_bytes {project_id!="",share_type!="",volume_type!="dp",volume_state="online",snapshot_policy="EC2_Backups"}[15m])))` | ||
snapmirrorPhysicalUsageQuery = `sum by (availability_zone, project_id, share_type) (max by (availability_zone, project_id, share_id, share_type) (last_over_time(netapp_volume_used_bytes {project_id!="",share_type!="",volume_type!="dp",volume_state="online",snapshot_policy="EC2_Backups"}[15m])))` | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This final bracket should stay, belongs to const (
on line 208
I was thinking in doing the same approach like we did for castellum in sapcc/helm-charts#5848 and move the logic under the control of the manila team (e.g. there are more updates to the snapmirror metrics in the queue) But this should better not happen at the same time like the switch from netapp-exporter to harvester metrics. What do you think? Do we want to first switch to harvester metrics (like proposed in this PR) and then move control over to manila team or the other way around? |
As part of netapp exporter migration, new metrics will be provided by
netapp harvest exporter.