Liquid nova report capacity #628
Draft
+1,305
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majewsky
reviewed
Dec 17, 2024
| return fmt.Errorf("while serializing Subcapacity Attributes: %w", err) | ||
| } | ||
| b.Subcapacities = append(b.Subcapacities, liquid.Subcapacity{ | ||
| // TODO: What should be the naming here? We list subcapacities for cores, ram and instances on the same split flavor capacity |
There was a problem hiding this comment.
I don't like there being multiple subcapacities for different aspects of the same thing. Let's have this as a single subcapacity with Capacity: 0, and all the actual data in attributes shaped like the old subcapacities.
internal/liquids/nova/usage.go
Outdated
|
|
||
| for _, subres := range allSubresources { | ||
| var attrs SubresourceAttributes | ||
| if err = json.Unmarshal(subres.Attributes, &attrs); err != nil { // TODO: Unmarshalling here + marshalling when building the subresources seems inefficient |
There was a problem hiding this comment.
Consider passing the subresources as type liquid.SubresourceBuilder[A] instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: