New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Check resource toplogy #620

Merged

majewsky merged 1 commit into master from resource_topology_fix

Dec 10, 2024

Member

VoigtS commented Dec 10, 2024

The previous implementation checked against a copied value. The default value was therfore discarded which resulted in an undesired error state.


          fix: check for toplogy in correct object instead of a copied value

032b886

VoigtS requested review from majewsky, SuperSandro2000 and Nuckal777 as code owners

December 10, 2024 12:51

coveralls commented Dec 10, 2024

coverage: 79.325%. remained the same
when pulling 032b886 on resource_topology_fix
into 8e808e2 on master.

majewsky approved these changes

View reviewed changes

majewsky merged commit 58337d1 into master

7 checks passed

majewsky deleted the resource_topology_fix branch

December 10, 2024 12:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet